Skip to content

fix: GetObjectsAsListV2Response should return ObjectWithURL #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
St4NNi merged 2 commits into from
Jun 26, 2023
Merged

fix: GetObjectsAsListV2Response should return ObjectWithURL #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b3815d
fix: GetObjectsAsListV2Response should return ObjectWithURL
lfbrehm Jun 26, 2023
90d3a25
fix: Added comments
lfbrehm Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aruna/api/storage/services/v1/object_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ service ObjectService {
//
// Status: ALPHA
//
// Gets a list of objects represented similar to a S3 ListObjectsV2 request
// Gets a list of ObjectWithURLs represented similar to a S3 ListObjectsV2 request
// !! Paths are collection specific !!
rpc GetObjectsAsListV2(GetObjectsAsListV2Request) returns (GetObjectsAsListV2Response) {
option (google.api.http) = {
Expand Down Expand Up @@ -828,7 +828,8 @@ message GetObjectsAsListV2Response {
bool is_truncated = 2;
uint32 max_keys = 4;
uint32 key_count = 5;
repeated storage.models.v1.Object contents = 6;
// Does not contain URLs, only paths
repeated ObjectWithURL contents = 6;
repeated CommonPrefix prefixes = 7;
optional string next_continuation_token = 8;
}
Expand Down