[2.0.0 beta.6] Licenses & Visibility annotations #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-Abroxas
reviewed
Oct 19, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
Made some suggestions to correct comments and naming. They can be addressed, but it wouldn't affect functionality if they were simply rejected.
Overall, it looks good to me and I will approve after the suggestions are applied or rejected 👍
lfbrehm
approved these changes
Oct 20, 2023
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major breaking update that adds licenses to all resources.
Changelog
Fixes #98