This repository was archived by the owner on Jun 26, 2023. It is now read-only.
refactor: Add extra warnings flags and apply first round of refactoring#77
Merged
Conversation
xmnlab
force-pushed
the
move-to-smart-pointers
branch
from
c26b062 to
e25349e
Compare
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add more extra warnings flags and apply the first round of refactoring,
mainly changing old casting to new casting approach and fixing some documentation issues
PR Checklist
Ensure that:
build: Changes that affect the build system or external dependencies (example scopes: cmake, meson, etc)ci: Changes to our CI configuration files and scripts (examples: CircleCi, SauceLabs)docs: Documentation only changesperf: A code change that improves performancerefactor: A code change that neither fixes a bug nor adds a featuretest: Adding missing tests or correcting existing testschore:Can be used as a generic task for tasks such as CI, test, support tasks or any other task that is not user facing task.feat:is used for a new feature or when a existent one is improved.fix:is used when a bug is fixed.BREAKING CHANGE:is used when there is a compatibility break.