Timeouts and Other Improvements#7
Merged
asantaga merged 10 commits intoasantaga:masterfrom Jan 12, 2020
msp1974:master
Merged
Conversation
Updated: Added timeout setting to all requests
… value - issue #4 Added: Function to check temperature is in valid range in set functions Updated: Improved logging output for setRoomMode errors Fixed: Manual mode temp will be set to min temp when scheduled temp is below minimum - issue #3 Updated: Created constants for off, min and max temp and used in functions instead of values
Updated: Replaced remaining values with off,min,max constants
Minor improvements
Fix for issue #1. Only shows warning if room has no TRVs or RoomStats
Fixed: Error calling temp range check
asantaga
approved these changes
Jan 12, 2020
Owner
asantaga
left a comment
asantaga
left a comment
There was a problem hiding this comment.
looks good, noticed one extra change which I'll make as a sub commit
Owner
|
Merged |
Owner
|
All merged but I dont know why github still thinks it isnt merged.. but it is...... weird.. Thanks for the merge, closing |
Owner
|
I worked it out... :-) this way the network graph is true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angelo,
I have added the timeout parameter to all requests.get and requests.patch calls.
Also added some functions to convert between wiser temp and decimal temp and ensure integer - issue #4 .
Have set temp to min temp when setting to manual if scheduled temp is below min (ie off)
Some improvements to error logging also.
Removed all values in functions to refer to constants for off, min, max.
Provided a fix for issue #1 by only showing warning is room has no TRVs or RoomStats.
KR
Mark