fix(onboarding): hero copy revision + opaque toast background#4
Merged
Merged
Conversation
Per growth-team revision: - 'You're ready to run at scale.' -> 'From zero to inference in seconds.' - Subheading rewritten to lead with provisioning + browser-side run. Co-authored-by: aschkanAH <aschkanAH@users.noreply.github.com>
The shadcn theme tokens for popover/border are stored as bare HSL component triplets (e.g. `0 0% 100%`), not full color values. The existing Toaster wired `--normal-bg: var(--popover)` directly, which resolves to `background: 0 0% 100%` — invalid CSS, so sonner falls back to its default semi-transparent surface and toasts render illegibly when overlaying page content (most visible on the onboarding 'Sample Batch Started' toast on top of the API key card). Wrap the tokens in `hsl(...)` so the resolved value is a valid opaque color. Co-authored-by: aschkanAH <aschkanAH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3 (already merged).
Changes
Onboarding hero copy — per growth-team revision:
You're ready to run at scale.→From zero to inference in seconds.Your workspace is fully provisioned. Run a sample payload right from your browser to see Doubleword in action.Sonner toast background fix (global) — the existing shared
Toasterwas forwarding the bare HSL-component shadcn tokens (var(--popover)→0 0% 100%) into sonner's--normal-bg/--normal-text/--normal-border. That resolves to invalid CSS (background: 0 0% 100%), so sonner falls through to its default semi-transparent surface. The most visible symptom was the onboarding "Sample Batch Started" toast rendering illegibly on top of the API key card, but the bug applies to every toast in the app. Wrapped the tokens inhsl(...)so the resolved values are real opaque colors.QA
pnpm run lintclean.pnpm exec tsc -b tsconfig.app.jsonclean.pnpm test -- --run: 498 / 498 passing.Risk
The toast fix is global. Toasts elsewhere in the app will gain an opaque card-style background instead of their previous translucent fallback. I didn't find any callers that relied on the see-through behaviour, but worth a smoke pass on
toast.success/toast.errorcallsites.