Skip to content

Fix codesigning issues on macOS #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scoopr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix codesigning issues on macOS #7

scoopr wants to merge 1 commit into from

Conversation

@scoopr
Copy link

@scoopr scoopr commented Dec 2, 2025 •
edited
Loading

The copy with -r breaks the codesigning signature, as it copies the symbolic link contents, instead of the link itself.

Changing it to -R fixes it on macOS.

Also the .app disk size is slightly smaller as the symbolic link contents is not duplicated.

Fixes #6

@scoopr
Fix codesigning issues on macOS
b833247 
The copy with `-r` breaks the codesigning signature, as it copies
the symbolic link contents, instead of the link itself.

Changing it to `-R` fixes it on macOS.

Also the .app disk size is slightly smaller as the symbolic link
contents is not duplicated.
@scoopr scoopr requested a review from a team as a code owner December 2, 2025 11:23
@scoopr
Copy link
Author

scoopr commented Dec 2, 2025

Trying to read if it changes anything for Linux, it looks like man page specifies -r and -R to be equivalent, and its actually the -P that controls the following of symlinks, which -R on macos implies. I'm fine either way.

@dsmurl dsmurl mentioned this pull request Dec 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac OS says the downloaded CMake app is damaged

1 participant

@scoopr