Fix for esphome 2023.12.x#4
Fix for esphome 2023.12.x#4daernsinstantfortress wants to merge 3 commits intoashald:lilygo-t5-47from
Conversation
daernsinstantfortress
left a comment
There was a problem hiding this comment.
In the last release of ESPHome, some small changes were done to the display
component, to make subcomponents leaner. With those changes, compilation breaks
if a display is trying to register as a component itself (this is now done
automatically when registering the display).
Also, DisplayBuffer now automatically inherits from PollingComponent, so there is no need to explicitly inherit from that.
|
I attempted to use your fork @daernsinstantfortress . However this fails against esphome 2023.12.9, reason is in 2023.12.9 the DisplayBufferRet no longer exists. |
|
@hagak Someone else reported something similar, but I've just retested as a clean build against my own 2023.12.9 install and it built ok using this: ...so I can't explain the mismatch in behaviour here. |
|
Well I mean if you go and look at esphome/esphome display component the DisplayBufferRet does not exist anymore. Maybe you have building against an older version? I know the fork you have is a pretty old fork of esphome and is not 2023.12.9. |
What does this implement/fix?
Fixes some compatibility issues introduced with changes in ESPHome 2023.12.0
Types of changes
Test Environment
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: