Move to using maven to compile java and run node via frontend-maven-plugin#1
Open
duttonw wants to merge 4 commits intoasherkin:modernization-experimentsfrom
Open
Move to using maven to compile java and run node via frontend-maven-plugin#1duttonw wants to merge 4 commits intoasherkin:modernization-experimentsfrom
duttonw wants to merge 4 commits intoasherkin:modernization-experimentsfrom
Conversation
…lugin via maven defined lifecycle
Fix Dot Notation for Packages in Tests
Owner
|
Sorry for the delay, I just saw this PR! I don't remember this fork at all I'm afraid - I pretty quickly abandoned this effort in favour of writing a new library from scratch, asherkin/java-object-serialization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also include github actions for auto building.
Seems there is 2 tests failing on this modernization. Was this working when you stopped all those years back?
It may be related to the move to valid package path for the classname.