Automated fix for refs/heads/deny_engine#10
Open
github-actions[bot] wants to merge 3 commits intodeny_enginefrom
Open
Automated fix for refs/heads/deny_engine#10github-actions[bot] wants to merge 3 commits intodeny_enginefrom
github-actions[bot] wants to merge 3 commits intodeny_enginefrom
Conversation
ashithasantosh
force-pushed
the
deny_engine
branch
from
a125249 to
4a67021
Compare
ashithasantosh
pushed a commit
that referenced
this pull request
Sep 16, 2022
…grpc#30901) Fun edge case: when `rand_string()` happen to generate numbers only, yaml interprets `deployment_id` label value as an integer, but k8s expects label values to be strings. K8s responds with a barely readable 400 Bad Request error: `ReadString: expects \" or n, but found 9, error found in #10 byte of ...|ent_id`. Prepending deployment name forces deployment_id into a string, as well as it's just a better description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PanCakes to the rescue!
We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that!
If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml