Conversation
added 2 commits
May 13, 2024 23:05
Owner
ashutoshgithubs
left a comment
There was a problem hiding this comment.
Hi @PranotiPD , Your PR seems fine and is good to merge. But before this, can you please demonstrate your work with a short video? Like performing the action on Remove button.
Author
|
Sure. I'll add it. @ashutoshgithubs |
Owner
Hi @PranotiPD , Please let me know if you are done with the above task on your PR review. |
|
Thank you for submitting this pull request. |
Author
WhatsApp.Video.2024-05-17.at.21.41.11_3815306e.mp4 |
Author
|
hey @ashutoshgithubs could you please review the PR and let me know if it is fine or if I need to make some changes? I have added the recording too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Title: Adding profile image remove button in the settings/edit profile page
resolve issue: #41
Type of change ☑️
What sort of change have you made:
Checklist: ☑️
Screenshot of the changes made in your work (if applicable):
How Has This Been Tested? ⚙️
Tested changes locally.