Skip to content

Remove dp#70

Open
PranotiPD wants to merge 8 commits into
ashutoshgithubs:DevG_Contributefrom
PranotiPD:remove-dp
Open

Remove dp#70
PranotiPD wants to merge 8 commits into
ashutoshgithubs:DevG_Contributefrom
PranotiPD:remove-dp

Conversation

@PranotiPD
Copy link
Copy Markdown

Issue Title: Adding profile image remove button in the settings/edit profile page

resolve issue: #41

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • [] I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshot of the changes made in your work (if applicable):

Screenshot (754)

How Has This Been Tested? ⚙️

Tested changes locally.

Copy link
Copy Markdown
Owner

@ashutoshgithubs ashutoshgithubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PranotiPD , Your PR seems fine and is good to merge. But before this, can you please demonstrate your work with a short video? Like performing the action on Remove button.

@PranotiPD
Copy link
Copy Markdown
Author

Sure. I'll add it. @ashutoshgithubs

@ashutoshgithubs
Copy link
Copy Markdown
Owner

Sure. I'll add it. @ashutoshgithubs

Hi @PranotiPD , Please let me know if you are done with the above task on your PR review.

@github-actions
Copy link
Copy Markdown

Thank you for submitting this pull request.
We will review the changes and get in contact with you as soon as possible.

@PranotiPD
Copy link
Copy Markdown
Author

WhatsApp.Video.2024-05-17.at.21.41.11_3815306e.mp4

@ashutoshgithubs

@PranotiPD
Copy link
Copy Markdown
Author

hey @ashutoshgithubs could you please review the PR and let me know if it is fine or if I need to make some changes? I have added the recording too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants