chore: fix remote_download_minimal flag for delivery#585
Merged
gregmagolan merged 1 commit intomainfrom Jan 3, 2024
Merged
Conversation
gregmagolan
force-pushed
the
test_delivery
branch
5 times, most recently
from
0f653c2 to
81b234a
Compare
gregmagolan
force-pushed
the
test_delivery
branch
3 times, most recently
from
97ba659 to
d4fdd8f
Compare
gregmagolan
changed the title
gregmagolan
force-pushed
the
test_delivery
branch
from
d4fdd8f to
2672b05
Compare
gregmagolan
force-pushed
the
test_delivery
branch
from
2672b05 to
1e06b26
Compare
jennymagolan
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there is a Bazel bug with
common --remote_download_minimalas the expansion to--nobuild_runfile_linksis not filtered out frombazel queryand bazel ERRORs out. See bazelbuild/bazel#18130 (comment) for more info.So instead we set
Type of change
Test plan