wallet daemon: sign / sign_transactions improvements #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biryukovmaxim
requested changes
Aug 28, 2025
wallet/grpc/server/src/service.rs
Outdated
Comment on lines
185
to
221
| if !is_send_all { | ||
| // Calculating minimum set of UTXO's | ||
| let mut selected_utxos = Vec::new(); | ||
| let mut accumulated_amount = 0u64; | ||
| let target_amount = amount + MAX_COMMISSION_GAP; | ||
|
|
||
| for utxo in sorted_utxos.iter() { | ||
| selected_utxos.push(utxo.clone()); | ||
| accumulated_amount += utxo.amount; | ||
|
|
||
| // Stop | ||
| if accumulated_amount >= target_amount { | ||
| break; | ||
| } | ||
| if selected_utxos.len() >= MAX_UTXOS_FOR_SINGLE_TX { | ||
| log::warn!("Reached maximum UTXO limit ({}) to avoid mass overflow", MAX_UTXOS_FOR_SINGLE_TX); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| info!( | ||
| "Selected {} UTXOs out of {} total, covering {} sompi", | ||
| selected_utxos.len(), | ||
| sorted_utxos.len(), | ||
| accumulated_amount | ||
| ); | ||
| sorted_utxos = selected_utxos; | ||
| } else { | ||
| if sorted_utxos.len() > MAX_UTXOS_FOR_SINGLE_TX { | ||
| log::info!( | ||
| "Too many UTXOs ({}), selecting {} largest UTXOs to avoid mass limit", | ||
| sorted_utxos.len(), | ||
| MAX_UTXOS_FOR_SINGLE_TX | ||
| ); | ||
| sorted_utxos.truncate(MAX_UTXOS_FOR_SINGLE_TX); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
i dont think this logic is needed. generator handles mass internally and can issue multiple transactions
wallet/grpc/server/src/service.rs
Outdated
Comment on lines
182
to
183
| let mut sorted_utxos = utxos; | ||
| sorted_utxos.sort_by(|a, b| b.amount.cmp(&a.amount)); |
Collaborator
There was a problem hiding this comment.
sorted_utxos.sort_unstable_by_key(|a|Reverse(a.amount))
wallet/grpc/server/src/service.rs
Outdated
|
|
||
| let utxos = account.clone().get_utxos(search_addresses, None).await.map_err(|err| Status::internal(err.to_string()))?; | ||
|
|
||
| info!("Found {} UTXOs with total value {} sompi", utxos.len(), utxos.iter().map(|utxo| utxo.amount).sum::<u64>()); |
Collaborator
There was a problem hiding this comment.
the value claculated below again. put the sum into some variable
wallet/grpc/server/src/service.rs
Outdated
| None // Search UTXO from all addresses in wallet | ||
| } else { | ||
| info!("Searching UTXOs in specified addresses: {:?}", from_addresses); | ||
| Some(from_addresses.clone()) |
wallet/grpc/server/Cargo.toml
Outdated
|
|
||
| tokio.workspace = true | ||
| tonic.workspace = true | ||
| log = "0.4.22" |
childhoodisend
force-pushed
the
release/wallet-daemon-sign
branch
2 times, most recently
from
e57c38f to
0eb670f
Compare
childhoodisend
force-pushed
the
release/wallet-daemon-sign
branch
from
0eb670f to
d10a46e
Compare
biryukovmaxim
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.