Skip to content

Implement some HttpRequest APIs against core#435

Merged
twsouthwick merged 12 commits into
mainfrom
tasou/http-request
Feb 16, 2022
Merged

Implement some HttpRequest APIs against core#435
twsouthwick merged 12 commits into
mainfrom
tasou/http-request

Conversation

@twsouthwick
Copy link
Copy Markdown
Contributor

@twsouthwick twsouthwick commented Feb 14, 2022

This implements most of the APIs except the request body and the collection types (i.e. headers and cookies).

This change also adds .NET 6.0 as a build target so that we can have better nullability warnings (.NET Core 3.1 is still built as well).

This implements most of the APIs except the request body and the collection types (i.e. headers and cookies).
@twsouthwick twsouthwick requested a review from pranavkm February 15, 2022 00:38
@twsouthwick
Copy link
Copy Markdown
Contributor Author

/cc @davidfowl @pranavkm

@pranavkm pranavkm requested a review from Tratcher February 15, 2022 00:58
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks fine. HttpRequest.IsLocal looks a little iffy, it would be good to get a sign off from @Tratcher before we merge it.

Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/SystemWebStartupFilter.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Comment thread src/SystemWebAdapters/src/HttpRequest.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants