Skip to content

set WaitForDataBeforeAllocatingBuffer to false for PlatformBenchmarks #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 2 commits into from
Apr 3, 2020
Merged

set WaitForDataBeforeAllocatingBuffer to false for PlatformBenchmarks #1469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6861963
set WaitForDataBeforeAllocatingBuffer to false for PlatformBenchmarks
adamsitnik Mar 30, 2020
b02fc3a
simplify threadCount config logic
adamsitnik Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/BenchmarksApps/Kestrel/PlatformBenchmarks/BenchmarkConfigurationHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,16 @@ public static IWebHostBuilder UseBenchmarksConfiguration(this IWebHostBuilder bu
{
builder.UseConfiguration(configuration);

// Handle the transport type
var webHost = builder.GetSetting("KestrelTransport");

// Handle the thread count
var threadCountRaw = builder.GetSetting("threadCount");
int? theadCount = null;

if (!string.IsNullOrEmpty(threadCountRaw) && Int32.TryParse(threadCountRaw, out var value))
{
theadCount = value;
}

builder.UseSockets(options =>
{
if (theadCount.HasValue)
if (int.TryParse(builder.GetSetting("threadCount"), out int threadCount))
{
options.IOQueueCount = theadCount.Value;
options.IOQueueCount = threadCount;
}

#if NETCOREAPP5_0
options.WaitForDataBeforeAllocatingBuffer = false;
#endif
});

return builder;
Expand Down