Skip to content

Update SDK to latest#948

Merged
pranavkm merged 4 commits intomasterfrom
prkrishn/update-sdk
Apr 3, 2019
Merged

Update SDK to latest#948
pranavkm merged 4 commits intomasterfrom
prkrishn/update-sdk

Conversation

@pranavkm
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm commented Apr 3, 2019

No description provided.

@pranavkm pranavkm force-pushed the prkrishn/update-sdk branch from 8560b83 to 6072d5c Compare April 3, 2019 01:30
@pranavkm
Copy link
Copy Markdown
Contributor Author

pranavkm commented Apr 3, 2019

@stephentoub, when attempting to pick up the latest SDK \ runtime, I see this build error on the Mac agents:

System.ComponentModel.Win32Exception (102): Operation not supported on socket
   at System.ConsolePal.EnsureInitializedCore()
   at System.ConsolePal.ControlCHandlerRegistrar.Register()
   at System.Console.add_CancelKeyPress(ConsoleCancelEventHandler value)
   at Microsoft.DotNet.Cli.Utils.ProcessReaper..ctor(Process process)
   at Microsoft.DotNet.Cli.Utils.ProcessStartInfoExtensions.Execute(ProcessStartInfo startInfo)
   at Microsoft.DotNet.Tools.RestoringCommand.Execute()
   at Microsoft.DotNet.Tools.Publish.PublishCommand.Run(String[] args)
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient)
   at Microsoft.DotNet.Cli.Program.Main(String[] args)

It's from a vanilla dotnet publish operation on a csproj. Could it be related to dotnet/corefx#35621?

The build log with the failure: https://dev.azure.com/dnceng/public/_build/results?buildId=141479&view=logs&lineStart=38&jobId=fe4e408a-5576-5fa1-f2ab-61ac24819df6&taskId=961b5bee-1b38-582a-dfd3-29c4c6c56ff0

@pranavkm pranavkm requested review from dougbu and jkotalik April 3, 2019 03:42
Copy link
Copy Markdown
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can make it work in AspNetCore, sure 😺 (Please revert if you can't update that repo for some reason.)

@pranavkm pranavkm merged commit fb72e2f into master Apr 3, 2019
@pranavkm pranavkm deleted the prkrishn/update-sdk branch April 3, 2019 13:30
pranavkm added a commit that referenced this pull request Apr 3, 2019
pranavkm added a commit that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants