This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Support repeated elements in XML configuration, this addresses #745 and #815 #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maintain a stack of elements that are encountered during traversal of the XML file - Detect sibling elements and automatically append indexes to the generated configuration keys, exactly like how the JSON configuration providers does for JSON arrays - Add a battery of unit tests to verify no existing features were broken in the process
|
|
- Add a unit test that covers this scenario (previously only functional tests failed) - Eagerly load the name attribute when an element is encountered, because it is needed for sibling detection.
amoerie
changed the title
Contributor
|
@amoerie After some discussion, we have decided that this would be a good PR to take, since it improves the XML experience with little risk of breaking real-world configs that already exist. We have recently consolidated the configuration code into the https://github.com/aspnet/Extensions repo. Unfortunately, it is not trivial to move PRs over to another repo, so will not be moving this PR over. However, it should not be too difficult to recreate in the new location if you wish to continue pursuing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a considerable change in the existing code, but all existing tests were not modified and are still green. The "Name" feature is still completely supported and as such, this is not a breaking change.
However, adding a "Name" is no longer required for repeated XML elements, the keys will be automatically populated with indexes instead. This is exactly how the JSON provider handles JSON arrays.
Feedback is most welcome!
Thank you for your consideration.