This repository was archived by the owner on Nov 20, 2018. It is now read-only.
[NoMerge] React to StringValues#1010
Closed
benaadams wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
e.g. currently its saying there is a header; then returning |
benaadams
force-pushed
the
react-to-StringValues
branch
from
3dc470a to
1fc26d4
Compare
Contributor
|
Looks like the tests fail with this change. |
Contributor
Author
Also needs dotnet/extensions#330 |
Contributor
Author
|
I can put a fix in (e.g. put |
Contributor
Author
|
Added fix back |
Member
|
Heads up, the original change was reverted. We'll reintroduce it more cautiously by doing full universe builds before merging. |
benaadams
force-pushed
the
react-to-StringValues
branch
from
0737724 to
65ca37e
Compare
benaadams
force-pushed
the
react-to-StringValues
branch
from
65ca37e to
f220f6e
Compare
|
We’re closing this PR because we don’t feel that this change is a good fit for the product at this time. We thank you for the contribution and look forward to collaborating more in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isn't it only
HeaderDictionarythat needs the change to not addnulls to the dictionary in theIDictionarypath as it does in theIHeaderDictionarypath?Also needs dotnet/extensions#330
/cc @Tratcher @ryanbrandenburg @dougbu @rynowak @halter73