Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Less StringValue struct copies for header existence checks#2014

Closed
benaadams wants to merge 2 commits into
aspnet:devfrom
benaadams:header-encoding
Closed

Less StringValue struct copies for header existence checks#2014
benaadams wants to merge 2 commits into
aspnet:devfrom
benaadams:header-encoding

Conversation

@benaadams
Copy link
Copy Markdown
Contributor

Less StringValue struct copies for header existence checks

  • check struct in-place

Lazy calc transfer coding

  • calc once existence is confirmed rather than always (since existence is checked anyway)

@benaadams
Copy link
Copy Markdown
Contributor Author

Pre

pre

Post

post

@ghost ghost removed the cla-already-signed label Nov 14, 2017
@davidfowl
Copy link
Copy Markdown
Member

This PR needs to do over. We refactored everything for http2. This looks like and easy win though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants