This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Less StringValue struct copies for header checks#2488
Merged
Merged
Conversation
Contributor
Author
|
Ubuntu 16.04 Release Build Failed DoesNotRejectRequestWithContentLengthHeaderExceedingGlobalLimitIfLimitDisabledPerRequest
Error Message:
System.TimeoutException : The operation at /_/test/shared/TestConnection.cs:129 timed out after reaching the limit of 60000ms.
Stack Trace:
at Microsoft.AspNetCore.Testing.TaskExtensions.<TimeoutAfter>d__0`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Testing.TestConnection.<Receive>d__21.MoveNext() in /_/test/shared/TestConnection.cs:line 131
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBodySizeTests.<DoesNotRejectRequestWithContentLengthHeaderExceedingGlobalLimitIfLimitDisabledPerRequest>d__2.MoveNext() in /_/test/Kestrel.FunctionalTests/MaxRequestBodySizeTests.cs:line 131
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) |
Contributor
Author
|
test Ubuntu 16.04 Release Build |
Contributor
Author
|
Odd error on Ubuntu 16.04 Release Build https://github.com/dotnet/corefx/issues/29075 |
Contributor
Author
|
test Ubuntu 16.04 Release Build |
Contributor
Author
|
OSX 10.12 Release Build |
halter73
reviewed
Apr 12, 2018
| if (hostText[offset] != ':' || hostText.Length == offset + 1) | ||
| var firstChar = hostText[offset]; | ||
| offset++; | ||
| if (firstChar != ':' || (uint)offset >= (uint)hostText.Length) |
Member
There was a problem hiding this comment.
The other uint casts look to be eliminating a comparison which I'm OK with. This looks like it's just for the JIT though.
Contributor
Author
There was a problem hiding this comment.
Sorta, its verifying offset is positive so the var i = offset in the for loop so the bounds checks can be eliminated in the for loop below.
However, the Jit still doesn't eliminate the bounds check at this time; so I can remove it? (doesn't really like doing it for things that start with variables)
Member
|
@Tratcher Can you review this? |
Member
|
Maybe tomorrow, I'm in meetings the rest of the day. |
Contributor
Author
|
OSX 10.12 Release Build Libuv tests failed with no explaination test Ubuntu 16.04 Release Build |
Member
|
The aborted test is probably related to #2454 |
Contributor
Author
|
Ubuntu 16.04 Release Build is grumpy test Ubuntu 16.04 Release Build |
Contributor
Author
|
Ubuntu 16.04 Release Build #2486 |
Contributor
Author
|
OSX 10.12 Release Build test OSX 10.12 Release Build |
Contributor
Author
|
OSX 10.12 Release Build test OSX 10.12 Release Build |
Tratcher
approved these changes
Apr 13, 2018
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
Are there current perf metrics? What's the gain?
Member
|
@Tratcher Thee are some benchmarks results with just this change in dotnet/coreclr#17512 (comment) under "Skip struct copies (improve implementations)". |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @halter73 @davidfowl something more like this?