Don't use Vector<byte>.Dot#494
Conversation
1f705c4 to
4460cd3
Compare
|
23%! That's great. We're going to run this in our perflab along with the StringValues change to a class (dotnet/extensions#68) and report back with the combined results. |
There was a problem hiding this comment.
Read that it's Jitted to a const, so can use it directly rather than cacing in variable; will try to find reference
|
What is the environment that you ran these tests on? (So I can make some apple to apple comparisons) |
|
It's hard to make apple-to-apple comparisons unless you run the baseline on the exact same machine. |
|
Apple to pear comparisons perhaps :P I was wondering if it was something "Standard-ish" like a A3 VM instance on Azure, or something... |
|
@darcythomas you need to run in release (SIMD optimizations are weakened in debug; so its possible to debug them). On a A3 VM you might max out its network first; I'm testing with G4 VMs as already above 2.3GBps sends. |
23% improvement in RPS
Faster implementation than using
Vector<byte>.DotResolves #493
Before
After