Fast path Consume when already complete

[benaadams]

Fast path Consume when content complete by not using async state machine (is normally complete)

From #519

[halter73]

I don't understand this. Why not put his call to ReadAsyncImplementation inside of ConsumeAwaited? You already do this inside the while condition.

[benaadams]

Yeah is a bit weird; enough to make me look at it for a good few minutes before working out why.

Is because the non-completed one passes in the current task so is to match that. Will have a think on how it can be made better.

[benaadams]

Swapped the parameters; and made the task have a null default. Better?

[halter73]

Will have to be updated post ValueTask merge, but aside from my one comment this is good to 🚢

[benaadams]

This is a a bit fiddly with the ValueTask; merge to rebase, will take a little bit of time.

[benaadams]

Closing this; I think I'd need to start again; too much code has changed in the merge. Likely to make mistakes.

[benaadams]

Rebased and reworked to work with the ValueTask changes

[halter73]