This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Optimize Memorypool block use#787
Merged
Merged
Conversation
+ Only use pooled blocks in tests
Member
|
@halter73 and I were discussing this yesterday 😄 |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only use pooled blocks in tests (tests only place not using pooled blocks)
Remove
GCHandlefrom blocks used for no longer present temp blocksRemove now redundant use of nooping
pin+unpinfunctions w/ memory blocksRemove unnecessary
fixedblocks as block pointer is fixed for lifetimeFrom #519
/cc @halter73 @CesarBS @davidfowl