Skip to content
This repository was archived by the owner on Nov 29, 2018. It is now read-only.

Package with csproj and build as AnyCPU#86

Closed
natemcmaster wants to merge 1 commit into
devfrom
namc/packaging
Closed

Package with csproj and build as AnyCPU#86
natemcmaster wants to merge 1 commit into
devfrom
namc/packaging

Conversation

@natemcmaster
Copy link
Copy Markdown
Contributor

@natemcmaster natemcmaster commented Feb 17, 2017

Remove makefile.shade and packages with csproj only
Build default .NET Framework assembly as AnyCPU instead of x64
Removes the dummy csproj for x86

@pranavkm
Copy link
Copy Markdown
Contributor

I was hoping we could remove a lot of this when we do https://github.com/aspnet/Coherence-Signed/issues/401. Let me consult with the powers to be and see if we can make that change here instead.

@natemcmaster
Copy link
Copy Markdown
Contributor Author

The package can target .NET Standard, but won't it still need to compile for .NET Framework and .NET Core?

Remove makefile.shade build target
@natemcmaster
Copy link
Copy Markdown
Contributor Author

🔔. Can we take care of the ".NET Framework or not" question in a separate PR? This one is just about removing the dependency on Sake to pack.

@pranavkm
Copy link
Copy Markdown
Contributor

I'd rather not make all these changes to the build if we can avoid it. If you'd like you could move the Sake reference to this project's repo.props once aspnet/KoreBuild#177 is addressed.

@natemcmaster
Copy link
Copy Markdown
Contributor Author

Can you explain why you want to stick with Sake? I won't make a PR to add Sake to this repo. We are actively working towards removing it completely from our build system.

@pranavkm
Copy link
Copy Markdown
Contributor

#90 should supersede this.

@natemcmaster natemcmaster deleted the namc/packaging branch February 22, 2017 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants