Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Adding VSTS file#2395

Merged
natemcmaster merged 3 commits into
release/2.2from
rybrande/VSTS
Jul 27, 2018
Merged

Adding VSTS file#2395
natemcmaster merged 3 commits into
release/2.2from
rybrande/VSTS

Conversation

@ryanbrandenburg
Copy link
Copy Markdown
Contributor

No description provided.

@ryanbrandenburg
Copy link
Copy Markdown
Contributor Author

It seems that there is a consistent hang on Linux for Razor soon after we see this suspicious test that doesn't appear on TeamCity:

Invalid argument(s).
2018-06-07T23:35:54.2252397Z   Usage:   
2018-06-07T23:35:54.2269856Z       dotnet razorpagegenerator <root-namespace-of-views> [path]
2018-06-07T23:35:54.2293757Z   Examples: 
2018-06-07T23:35:54.2309237Z       dotnet razorpagegenerator Microsoft.AspNetCore.Diagnostics.RazorViews
2018-06-07T23:35:54.2325333Z           - processes all views in "Views" subfolders of the current directory
2018-06-07T23:35:54.2341856Z       dotnet razorpagegenerator Microsoft.AspNetCore.Diagnostics.RazorViews c:\project
2018-06-07T23:35:54.2609231Z           - processes all views in "Views" subfolders of c:\project directory
2018-06-07T23:35:54.2625971Z   
2018-06-07T23:35:54.2639536Z   
2018-06-07T23:35:54.2654103Z     Generating code files for views in /opt/vsts/work/1/s/test/RazorPageGenerator.Test/TestFiles/Views
2018-06-07T23:35:54.2807679Z       Generating code file for view TestView.cshtml...
2018-06-07T23:35:54.2822465Z         Inlining file TestFile.js
2018-06-07T23:35:54.2840164Z         Done!

@NTaylorMullen do you have time to look into this or know of another Razor person who does?

@ryanbrandenburg
Copy link
Copy Markdown
Contributor Author

Talked to Taylor in person, I'm going to see about getting him an image of the build machine that failed.

@ryanbrandenburg
Copy link
Copy Markdown
Contributor Author

We're stalled on this until we can get a docker image that we can use to diagnose. I've talked to some people on the VSTS team, hopefully they have info soon.

@ryanbrandenburg
Copy link
Copy Markdown
Contributor Author

This is stalled. Our current thinking is that something is causing the VSTS agent to lose connection with the server (maybe killing a process?), but we can't diagnose that ourselves so we need the VSTS people to look into it.

@natemcmaster
Copy link
Copy Markdown
Contributor

Is this better now that we have more agents?

@ryanbrandenburg
Copy link
Copy Markdown
Contributor Author

Looks like no, I don't think it's a matter of number of build agents so much as a communication problem between agent and server. Possibly our scripts hang in VSTS for some weird environment reason, but we're looking into it.

@natemcmaster natemcmaster changed the base branch from dev to master July 2, 2018 17:58
@natemcmaster natemcmaster changed the base branch from master to release/2.2 July 26, 2018 17:54
@natemcmaster natemcmaster self-assigned this Jul 26, 2018
@natemcmaster
Copy link
Copy Markdown
Contributor

I've been chatting with the VSTS folks. It looks like there is something in the VSTS infrastructure which doesn't play nice with background processes, such as rzc. I'm going to disable tests on VSTS Linux builds for now since we have coverage that works on Jenkins and TeamCity.

@natemcmaster
Copy link
Copy Markdown
Contributor

@rynowak are there known issues with the tests "Queue_ProcessesNotifications_AndGoesBackToSleep"? It consistently fails on Windows in VSTS

image

@natemcmaster natemcmaster requested a review from HaoK July 26, 2018 20:50
@natemcmaster
Copy link
Copy Markdown
Contributor

Queue_ProcessesNotifications_AndRestarts failed on Jenkins, so I'm going to open this as a flaky bug issue.

@HaoK can you review?

@natemcmaster
Copy link
Copy Markdown
Contributor

#2506

@rynowak
Copy link
Copy Markdown
Member

rynowak commented Jul 26, 2018

Yeah I think it's F L A K Y

@natemcmaster
Copy link
Copy Markdown
Contributor

I've opened #2506 to follow up on flaky tests and #2507 to follow up on re-enabling Linux.

@natemcmaster natemcmaster merged commit afc6717 into release/2.2 Jul 27, 2018
@natemcmaster natemcmaster deleted the rybrande/VSTS branch July 27, 2018 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants