Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 36 additions & 30 deletions src/Microsoft.AspNetCore.Razor.Language/ClassifiedSpanVisitor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public override SyntaxNode VisitCSharpCodeBlock(CSharpCodeBlockSyntax node)
if (node.Parent is CSharpStatementBodySyntax ||
node.Parent is CSharpExpressionBodySyntax ||
node.Parent is CSharpImplicitExpressionBodySyntax ||
node.Parent is CSharpDirectiveBodySyntax)
node.Parent is RazorDirectiveBodySyntax)
{
return base.VisitCSharpCodeBlock(node);
}
Expand All @@ -58,31 +58,31 @@ public override SyntaxNode VisitCSharpImplicitExpression(CSharpImplicitExpressio
return WriteBlock(node, BlockKindInternal.Expression, base.VisitCSharpImplicitExpression);
}

public override SyntaxNode VisitCSharpDirective(CSharpDirectiveSyntax node)
public override SyntaxNode VisitRazorDirective(RazorDirectiveSyntax node)
{
return WriteBlock(node, BlockKindInternal.Directive, base.VisitCSharpDirective);
return WriteBlock(node, BlockKindInternal.Directive, base.VisitRazorDirective);
}

public override SyntaxNode VisitCSharpTemplateBlock(CSharpTemplateBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.Template, base.VisitCSharpTemplateBlock);
}

public override SyntaxNode VisitHtmlMarkupBlock(HtmlMarkupBlockSyntax node)
public override SyntaxNode VisitMarkupBlock(MarkupBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.Markup, base.VisitHtmlMarkupBlock);
return WriteBlock(node, BlockKindInternal.Markup, base.VisitMarkupBlock);
}

public override SyntaxNode VisitHtmlTagBlock(HtmlTagBlockSyntax node)
public override SyntaxNode VisitMarkupTagBlock(MarkupTagBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.Tag, base.VisitHtmlTagBlock);
return WriteBlock(node, BlockKindInternal.Tag, base.VisitMarkupTagBlock);
}

public override SyntaxNode VisitHtmlAttributeBlock(HtmlAttributeBlockSyntax node)
public override SyntaxNode VisitMarkupAttributeBlock(MarkupAttributeBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.Markup, n =>
{
var equalsSyntax = SyntaxFactory.HtmlTextLiteral(new SyntaxList<SyntaxToken>(node.EqualsToken));
var equalsSyntax = SyntaxFactory.MarkupTextLiteral(new SyntaxList<SyntaxToken>(node.EqualsToken));
var mergedAttributePrefix = MergeTextLiteralSpans(node.NamePrefix, node.Name, node.NameSuffix, equalsSyntax, node.ValuePrefix);
Visit(mergedAttributePrefix);
Visit(node.Value);
Expand All @@ -92,7 +92,7 @@ public override SyntaxNode VisitHtmlAttributeBlock(HtmlAttributeBlockSyntax node
});
}

public override SyntaxNode VisitHtmlMinimizedAttributeBlock(HtmlMinimizedAttributeBlockSyntax node)
public override SyntaxNode VisitMarkupMinimizedAttributeBlock(MarkupMinimizedAttributeBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.Markup, n =>
{
Expand All @@ -103,14 +103,14 @@ public override SyntaxNode VisitHtmlMinimizedAttributeBlock(HtmlMinimizedAttribu
});
}

public override SyntaxNode VisitHtmlCommentBlock(HtmlCommentBlockSyntax node)
public override SyntaxNode VisitMarkupCommentBlock(MarkupCommentBlockSyntax node)
{
return WriteBlock(node, BlockKindInternal.HtmlComment, base.VisitHtmlCommentBlock);
return WriteBlock(node, BlockKindInternal.HtmlComment, base.VisitMarkupCommentBlock);
}

public override SyntaxNode VisitHtmlDynamicAttributeValue(HtmlDynamicAttributeValueSyntax node)
public override SyntaxNode VisitMarkupDynamicAttributeValue(MarkupDynamicAttributeValueSyntax node)
{
return WriteBlock(node, BlockKindInternal.Markup, base.VisitHtmlDynamicAttributeValue);
return WriteBlock(node, BlockKindInternal.Markup, base.VisitMarkupDynamicAttributeValue);
}

public override SyntaxNode VisitRazorMetaCode(RazorMetaCodeSyntax node)
Expand All @@ -125,10 +125,10 @@ public override SyntaxNode VisitCSharpTransition(CSharpTransitionSyntax node)
return base.VisitCSharpTransition(node);
}

public override SyntaxNode VisitHtmlTransition(HtmlTransitionSyntax node)
public override SyntaxNode VisitMarkupTransition(MarkupTransitionSyntax node)
{
WriteSpan(node, SpanKindInternal.Transition);
return base.VisitHtmlTransition(node);
return base.VisitMarkupTransition(node);
}

public override SyntaxNode VisitCSharpStatementLiteral(CSharpStatementLiteralSyntax node)
Expand All @@ -143,33 +143,39 @@ public override SyntaxNode VisitCSharpExpressionLiteral(CSharpExpressionLiteralS
return base.VisitCSharpExpressionLiteral(node);
}

public override SyntaxNode VisitCSharpHiddenLiteral(CSharpHiddenLiteralSyntax node)
public override SyntaxNode VisitCSharpEphemeralTextLiteral(CSharpEphemeralTextLiteralSyntax node)
{
WriteSpan(node, SpanKindInternal.Code);
return base.VisitCSharpHiddenLiteral(node);
return base.VisitCSharpEphemeralTextLiteral(node);
}

public override SyntaxNode VisitCSharpNoneLiteral(CSharpNoneLiteralSyntax node)
public override SyntaxNode VisitUnclassifiedTextLiteral(UnclassifiedTextLiteralSyntax node)
{
WriteSpan(node, SpanKindInternal.None);
return base.VisitCSharpNoneLiteral(node);
return base.VisitUnclassifiedTextLiteral(node);
}

public override SyntaxNode VisitHtmlLiteralAttributeValue(HtmlLiteralAttributeValueSyntax node)
public override SyntaxNode VisitMarkupLiteralAttributeValue(MarkupLiteralAttributeValueSyntax node)
{
WriteSpan(node, SpanKindInternal.Markup);
return base.VisitHtmlLiteralAttributeValue(node);
return base.VisitMarkupLiteralAttributeValue(node);
}

public override SyntaxNode VisitHtmlTextLiteral(HtmlTextLiteralSyntax node)
public override SyntaxNode VisitMarkupTextLiteral(MarkupTextLiteralSyntax node)
{
if (node.Parent is HtmlLiteralAttributeValueSyntax)
if (node.Parent is MarkupLiteralAttributeValueSyntax)
{
return base.VisitHtmlTextLiteral(node);
return base.VisitMarkupTextLiteral(node);
}

WriteSpan(node, SpanKindInternal.Markup);
return base.VisitHtmlTextLiteral(node);
return base.VisitMarkupTextLiteral(node);
}

public override SyntaxNode VisitMarkupEphemeralTextLiteral(MarkupEphemeralTextLiteralSyntax node)
{
WriteSpan(node, SpanKindInternal.Markup);
return base.VisitMarkupEphemeralTextLiteral(node);
}

private SyntaxNode WriteBlock<TNode>(TNode node, BlockKindInternal kind, Func<TNode, SyntaxNode> handler) where TNode : SyntaxNode
Expand Down Expand Up @@ -208,7 +214,7 @@ private void WriteSpan(SyntaxNode node, SpanKindInternal kind)
_spans.Add(span);
}

private HtmlTextLiteralSyntax MergeTextLiteralSpans(params HtmlTextLiteralSyntax[] literalSyntaxes)
private MarkupTextLiteralSyntax MergeTextLiteralSpans(params MarkupTextLiteralSyntax[] literalSyntaxes)
{
if (literalSyntaxes == null || literalSyntaxes.Length == 0)
{
Expand All @@ -234,16 +240,16 @@ private HtmlTextLiteralSyntax MergeTextLiteralSpans(params HtmlTextLiteralSyntax
seenFirstLiteral = true;
}

foreach (var token in syntax.TextTokens)
foreach (var token in syntax.LiteralTokens)
{
builder.Add(token.Green);
}
}

var mergedLiteralSyntax = Syntax.InternalSyntax.SyntaxFactory.HtmlTextLiteral(
var mergedLiteralSyntax = Syntax.InternalSyntax.SyntaxFactory.MarkupTextLiteral(
builder.ToList<Syntax.InternalSyntax.SyntaxToken>());

return (HtmlTextLiteralSyntax)mergedLiteralSyntax.CreateRed(parent, position);
return (MarkupTextLiteralSyntax)mergedLiteralSyntax.CreateRed(parent, position);
}

private SourceSpan GetSourceSpanForNode(SyntaxNode node)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public RazorSyntaxTree Verify()
return rewrittenTree;
}

public override SyntaxNode VisitCSharpDirective(CSharpDirectiveSyntax node)
public override SyntaxNode VisitRazorDirective(RazorDirectiveSyntax node)
{
if (_nestedLevel > 0)
{
Expand All @@ -63,7 +63,7 @@ public override SyntaxNode VisitCSharpDirective(CSharpDirectiveSyntax node)
node = node.AppendDiagnostic(error);
}
_nestedLevel++;
var result = base.VisitCSharpDirective(node);
var result = base.VisitRazorDirective(node);
_nestedLevel--;

return result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ public override void VisitMarkupSpan(MarkupChunkGenerator chunkGenerator, Span s
{
var token = span.Tokens[0];
if (token != null &&
token.Kind == SyntaxKind.Unknown &&
token.Kind == SyntaxKind.Marker &&
token.Content.Length == 0)
{
// We don't want to create IR nodes for marker tokens.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ private void ExplicitExpression()
// If necessary, put an empty-content marker token here
if (Span.Tokens.Count == 0)
{
Accept(SyntaxFactory.Token(SyntaxKind.Unknown, string.Empty));
Accept(SyntaxFactory.Token(SyntaxKind.Marker, string.Empty));
}

// Output the content span and then capture the ")"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public override string GetSample(SyntaxKind kind)

public override SyntaxToken CreateMarkerToken()
{
return SyntaxFactory.Token(SyntaxKind.Unknown, string.Empty);
return SyntaxFactory.Token(SyntaxKind.Marker, string.Empty);
}

public override SyntaxKind GetKnownTokenType(KnownTokenType type)
Expand All @@ -138,7 +138,7 @@ public override SyntaxKind GetKnownTokenType(KnownTokenType type)
case KnownTokenType.CommentBody:
return SyntaxKind.RazorCommentLiteral;
default:
return SyntaxKind.Unknown;
return SyntaxKind.Marker;
}
}

Expand All @@ -164,7 +164,7 @@ public override SyntaxKind FlipBracket(SyntaxKind bracket)
return SyntaxKind.LessThan;
default:
Debug.Fail("FlipBracket must be called with a bracket character");
return SyntaxKind.Unknown;
return SyntaxKind.Marker;
}
}

Expand Down
Loading