Skip to content

Add unicycler#156

Merged
ODiogoSilva merged 2 commits intoassemblerflow:devfrom
sjackman:unicycler
Oct 21, 2018
Merged

Add unicycler#156
ODiogoSilva merged 2 commits intoassemblerflow:devfrom
sjackman:unicycler

Conversation

@sjackman
Copy link
Contributor

No description provided.

@sjackman sjackman mentioned this pull request Oct 18, 2018
15 tasks
@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #156 into dev will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #156      +/-   ##
==========================================
+ Coverage   43.26%   43.33%   +0.06%     
==========================================
  Files          63       63              
  Lines        5878     5885       +7     
==========================================
+ Hits         2543     2550       +7     
  Misses       3335     3335
Impacted Files Coverage Δ
flowcraft/generator/engine.py 90.96% <ø> (ø) ⬆️
flowcraft/generator/components/assembly.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d494f5...e210082. Read the comment docs.

Copy link
Collaborator

@ODiogoSilva ODiogoSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll! 😄

@ODiogoSilva
Copy link
Collaborator

Ah, could you just update the changelog.md with the new component?

@jacarrico
Copy link
Collaborator

Just a note: Unicycler uses several modules such as spades correct?
Ideally, Unicycler should be also be broken down in components and be represented as a FlowCraft recipe . Am I correct ?

@sjackman
Copy link
Contributor Author

sjackman commented Oct 18, 2018

Just a note: Unicycler uses several modules such as spades correct?

Correct. The stages for short-read assembly are…

  1. Correct reads with SPAdes
  2. Assemble reads with SPAdes at multiple values of k, and choose the best assembly
  3. Estimate copy number of unitigs
  4. Clean the assembly graph
  5. Apply SPAdes repeat resolution
  6. Polish the assembly with Pilon
  7. Rotate circular contigs to the starting gene dnaA or repA

Ideally, Unicycler should be also be broken down in components and be represented as a FlowCraft recipe . Am I correct ?

Yep! The plan is to separate it out into the components that are separable. Unicycler is not really designed to be split up, but some steps could be separated. Read correction and polishing for example would be easy to separate.

@sjackman
Copy link
Contributor Author

Unicycler has the options --no_correct, --no_rotate, and --no_pilon.

@sjackman
Copy link
Contributor Author

I've added --no_correct and --no_pilon to the default options.

@sjackman sjackman force-pushed the unicycler branch 2 times, most recently from 98198f1 to 2e45d9c Compare October 18, 2018 19:01
@sjackman
Copy link
Contributor Author

Ah, could you just update the changelog.md with the new component?

Done. Good to go?

@ODiogoSilva ODiogoSilva merged commit 4c63ced into assemblerflow:dev Oct 21, 2018
@sjackman sjackman deleted the unicycler branch October 21, 2018 17:55
@sjackman
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants