OUT-3165 | Highlight selected buttons on toolbar when active.#41
Open
arpandhakal wants to merge 1 commit intomainfrom
Open
OUT-3165 | Highlight selected buttons on toolbar when active.#41arpandhakal wants to merge 1 commit intomainfrom
arpandhakal wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
getActionStatecallback onToolbarProvider.getActionStatetoo.getActionStatecallback didn't cater to editor changes since the editor contents aren't reactive. Applied a temporary mechanism to rerender the editor. This is a bad practice. We should implement listening to editor content changes like we do for app bridge when all things are merged.Testing Criteria