Open
Conversation
- [x] migration that renames column: viewers to associations and add shared column - [x] association selector and share with client toggle components - [x] task can be shared only if assocaition is selected and assignee is IU - [x] task can be created with no assignee and only associations - [x] zod validation to meet association and shared conditions
… smaller functions
…ms/tasks-app into feature/client-association
The @assembly-js/node-sdk assemblyApi() factory is async and returns a Promise<AssemblyAPI>, but was being assigned synchronously in the constructor. This caused all SDK method calls to operate on a Promise object instead of the resolved client. Uses lazy init (store the promise, await in each method) to fix this with zero changes to external call sites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use ReturnType<typeof assemblyApi> instead of explicit Promise<SDK> so the type stays correct regardless of whether the SDK exports a sync or async factory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix: await async assemblyApi() factory with lazy init pattern
- [x] optimistic UI update and change in task update api - [x] allow to select association when assignee is IU or no assignee - [x] share a task with association when assignee is IU - [x] activity log when a task is shared/stopped sharing with association - [x] UI implementation
… changed of shared task - [x] show dialog when assignee is removed - [x] show dialog when assignee is changed to CU - [x] if assignee is CU, drop associations - [x] code refactor: rename functions, variable that matches association behavior
- [x] show dialog when task is shared and assignee is remove or replaced by CU
- [x] remove viewer filter and add association filter in task list/board view
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes