OUT-3179 | Resetting association from public API on task update endpoint does not work#1136
Merged
arpandhakal merged 3 commits intoOUT-3178from Feb 23, 2026
Merged
OUT-3179 | Resetting association from public API on task update endpoint does not work#1136arpandhakal merged 3 commits intoOUT-3178from
arpandhakal merged 3 commits intoOUT-3178from
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
priosshrsth
requested changes
Feb 23, 2026
| } else if (data.associations?.length) { | ||
| associations = await this.validateAssociations(data.associations) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
@arpandhakal This could be simplified or organized to make it more understandable.
eg create a function that initally checks the condition in line 342. If like 342 is true, it returns empty array.
It then validate associatsions agains schema, after that if result is empty, it again returns empty array. Otherwise. It returns this.validateAssociations(...)
…ts reset condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria
-Case 2 : when association is empty but isShared is on.
-Case 3 : when internalUserId is null but isShared is on.
-Case 4 : removing association with isShared off.
