Open
Conversation
- Filter tax rate lookup by OUTPUT ReportTaxType to prevent matching INPUT (purchase) tax rates. AU Xero tenants have both GST on Income (OUTPUT) and GST on Purchases (INPUT) at 10%, so matching by effectiveRate alone could apply the wrong tax type to invoices. - Explicitly set reportTaxType: OUTPUT when creating new tax rates. - Rename tax labels from "Assembly Sales Tax" to "Assembly Tax" for region-neutral naming. - Replace hardcoded USD currency formatting in ProductMappingTableRow with dynamic currency from the price object. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reportTaxTypeso Australian tenants select "GST on Income" (OUTPUT, 10%) instead of accidentally matching "GST on Purchases" (INPUT, 10%). Previously, matching was byeffectiveRatealone, which is ambiguous when AU tenants have both INPUT and OUTPUT rates at the same percentage.item.price.currencydynamically (with USD fallback) instead of hardcodingen-US/USD. Australian products will displayA$correctly.sync-logsroutemaxDurationfrom 800 → 300 to comply with Vercel Pro plan limits.Changes
SyncedTaxRates.service.ts(core fix)OUTPUT_TAX_TYPESset covering all valid sales tax report types (OUTPUT,OUTPUT2,SALESOUTPUT,CAPITALSALESOUTPUT,USSALESTAX)effectiveRateANDisOutputTaxRate()reportTaxType: OUTPUTon tax rate creation payload so newly created rates are properly taggedProductMappingTableRow.tsx(currency fix)renderUSD()withformatCurrency()that readsitem.price.currency || 'USD'Intl.NumberFormat(undefined, ...)so locale is auto-detected from browsersync-logs/route.ts(deployment fix)maxDuration800 → 300How to test
reportTaxType: OUTPUT(e.g., "GST on Income"), NOTINPUTreportTaxType: OUTPUTA$(AUD) formatting, not$(USD)🤖 Generated with Claude Code