Fixes #105, addressing comments for #106 #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `findGetterDescriptionForField(FieldDescription base)` to check against all known prefixes for methods that clash * Extended test case for FieldPropertyClash to include predicate case
* Addresses comments from @joel-costigliola in assertj#106 * Broke method into two: one for presence, one for getting the values * Added many more tests
| return o1.length() - o2.length(); | ||
| } | ||
| }); | ||
| SortedSet<String> packages = new TreeSet<>(Comparator.comparing(String::length)); |
Member
There was a problem hiding this comment.
sorry still on java 7 !
| this.declaredFieldsDescriptions.addAll(declaredFieldDescriptions); | ||
| } | ||
|
|
||
| Stream<GetterDescription> getGetterStreamForField(FieldDescription base) { |
Member
There was a problem hiding this comment.
same thing java 7 only 😿 will be java 8 for 3.0
Contributor
Author
There was a problem hiding this comment.
We should probably add the restriction to Maven. I forgot and IntelliJ let me do it, so I just went with it. :(
Member
There was a problem hiding this comment.
I'm integrating this PR and reworking it to use java 7
Contributor
Author
There was a problem hiding this comment.
Damn, I forgot about this -- I'm sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #106.
Addresses comments from #106, adds more tests, includes commit with fixes for #105.
Closes #105, #106.