Merged
Conversation
…RE -> needed for test (auto-revert) mode
…ble in subsequent files, added testModelButtons, added testMode options, added testStatus in statusBar
…depending on ARE status, added logic for "testModel" (auto-revert) functionality, added logic for settings for test mode (enable/disable and timeout)
…ge button sizes for testmode
Contributor
Author
|
adapted status bar, now looks like this: I think it makes sense to give the user the possibility to also approve a model that is currently being tested ;) |
Contributor
|
Hi, I really like the idea!! 👍 |
Contributor
|
what about this PR? I think we can merge it. Maybe you could add a shortcut as you already know how to do it :-) |
Contributor
Author
|
for now I'll merge it as it is, the shortcut can be added later... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an new optional "test-and-auto-revert" mode to WebACS.
Background: one of our clients uses an AsTeRICS based computer control and would like to be able to adapt the solution on his own. Unfortunately this is currently not possible because as soon as he clicks "upload model" in ACS the old (computer control) model is stopped and it's not possible to do a click on "start model" afterwards.
Idea: my approch is a mode where the user can click on "test model" which uploads and starts the current model in ACS and sets a timer for reverting it to the old model after e.g. 30 seconds. Therefore a user with an AsTeRICS based computer control solution can safely edit and test his own models.
Implementation:
In "Misc." menu I've added two options:
By enabling
test-auto-revert modethe menu changes to:-->
Upload Modelchanges toTest modeland there is noStop ModelorPause Modelanymore in order to prevent unintended stopping of the (computer control) model.A click on
Test modeluploads and starts the current model and starts a timer that is shown in the status bar:After the time is finished the previous (working computer control) model is re-uploaded and started. The timeout can be prolonged or directly cancelled using the provided buttons.
TODO:
the options in
Misc.are added in a quick and dirty way - what do you think you it should look like?