Skip to content

Conversation

@rukai
Copy link
Contributor

@rukai rukai commented Jun 11, 2024

This PR runs cargo clippy --fix and commits the changes it made.
You can reproduce the same changes by running that command yourself.

I have reviewed the changes and not seen anything controversial in there.
This includes:

@rukai
Copy link
Contributor Author

rukai commented Oct 24, 2024

I reran cargo clippy --fix to pull in any new fixes added since june.
I added in a separate commit in case you had previously partially reviewed the changes.

One of the new changes was fixing of this lint: https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
clippy --fix resolved the issue by adding more > but I think that in reality this block should use quote blocks which looks much better.

Before:
image
After:
image

The other new change is uncontroversial.

Hoping you'll be able to take a look at this PR as well.

@astonbitecode astonbitecode merged commit 9d82962 into astonbitecode:master Oct 30, 2024
@astonbitecode
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants