Skip to content

Set PowerPC Page Size to 64KB#10080

Merged
MichaReiser merged 1 commit into
mainfrom
ppc-page-size
Feb 23, 2024
Merged

Set PowerPC Page Size to 64KB#10080
MichaReiser merged 1 commit into
mainfrom
ppc-page-size

Conversation

@MichaReiser
Copy link
Copy Markdown
Member

@MichaReiser MichaReiser commented Feb 22, 2024

Summary

Fixes #10073

We had a similar issue with aarch64 and the fix was to increase the page size to 64KB: #3791 (comment)

The issue seems to be that jemalloc is compiled with fixed page sizes and using a larger page size than what it is compiled for segfaults. But jemalloc supports running on systems with smaller page sizes then configured at compile time.
Sources: [1, 2]

This PR does the same for PowerPC because widely used PowerPC systems use a default page size of 64KB source

Test Plan

@nwf tested the built binary on their power pc

@MichaReiser MichaReiser added the bug Something isn't working label Feb 22, 2024
@MichaReiser
Copy link
Copy Markdown
Member Author

@nwf could you try one of the power pc binaries from (either wheel or from binaries) and report back if they are now working for you?

https://github.com/astral-sh/ruff/actions/runs/8005385997#artifacts

I can't test it myself because I don't have a power pc cpu

@nwf
Copy link
Copy Markdown

nwf commented Feb 23, 2024

Much better, thanks!

0abaa1dc35a7% ./ruff 
Ruff: An extremely fast Python linter.

@MichaReiser
Copy link
Copy Markdown
Member Author

Awesome. Thank you @nwf for testing the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerPC pip package is not suitable for systems with 64 KiB pages

3 participants