Fix E301 not triggering on decorated methods.#10117
Merged
MichaReiser merged 4 commits intoMar 1, 2024
Merged
Conversation
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| E301 | 73 | 2 | 71 | 0 | 0 |
| PLR0917 | 18 | 9 | 9 | 0 | 0 |
| PLR0904 | 4 | 2 | 2 | 0 | 0 |
| PLW1641 | 2 | 1 | 1 | 0 | 0 |
MichaReiser
added
bug
MichaReiser
approved these changes
Feb 26, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
That was quick! Thank you
Contributor
Author
|
@MichaReiser Since it was a really small fix, should I rebase it on main so that the fix can be merged quicker ? |
Member
|
@hoel-bagard yeah that might be worth it. I thought the other PR's are quick wins but that's not the case :( |
Contributor
Author
|
@MichaReiser Ok, I'll do that. Is there a way I can help with the other PR ? |
Member
|
That's very kind of you! The main struggle is finding a good way to make |
hoel-bagard
force-pushed
the
hoel/fix-blank-lines-classmethods
branch
from
32b031f to
8854ded
Compare
MichaReiser
force-pushed
the
hoel/fix-blank-lines-classmethods
branch
from
8854ded to
b108cee
Compare
MichaReiser
approved these changes
Mar 1, 2024
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
Co-authored-by: Micha Reiser <micha@reiser.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #10098.
Summary
This PR fixes #10114.
Test Plan
The example given in the issue has been added to the fixtures, and the results compared with pycodestyle.