Make --config and --isolated global flags#10150
Merged
Merged
Conversation
AlexWaygood
commented
Feb 28, 2024
MichaReiser
reviewed
Feb 28, 2024
MichaReiser
approved these changes
Feb 28, 2024
MichaReiser
reviewed
Feb 28, 2024
Contributor
|
AlexWaygood
commented
Feb 28, 2024
MichaReiser
approved these changes
Feb 29, 2024
MichaReiser
reviewed
Feb 29, 2024
MichaReiser
reviewed
Feb 29, 2024
MichaReiser
reviewed
Feb 29, 2024
Member
Author
|
Alright, ready for another look, I think 😅 the implementation now uses |
MichaReiser
reviewed
Mar 4, 2024
MichaReiser
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9892.
This PR makes
--configand--isolatedglobal flags that are accepted by all ruff subcommands: ruff will no longer error out if a redundant--configargument is passed to a command such asruff versionorruff rule. The flag has no effect for subcommands that do not need it (but it is still validated).Test Plan
There were no tests for
ruff version, so I added them as part of this PR, and used the new tests to assert that the--configflag is now accepted byruff version. I also manually tested to check things were working as expected.