Fix RUF028 not allowing # fmt: skip on match cases#10178
Merged
Conversation
Contributor
|
MichaReiser
approved these changes
Mar 1, 2024
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
## Summary Fixes astral-sh#10174 by allowing match cases to be enclosing nodes for suppression comments. `else/elif` clauses are now also allowed to be enclosing nodes. ## Test Plan I've added the offending code from the original issue to the `RUF028` snapshot test, and I've also expanded it to test the allowed `else/elif` clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10174 by allowing match cases to be enclosing nodes for suppression comments.
else/elifclauses are now also allowed to be enclosing nodes.Test Plan
I've added the offending code from the original issue to the
RUF028snapshot test, and I've also expanded it to test the allowedelse/elifclause.