Check for use of debugpy and ptvsd debug modules (#10177)#10194
Merged
charliermarsh merged 1 commit intoMar 2, 2024
Conversation
jeremy-hiatt
commented
Mar 2, 2024
Comment on lines
+112
to
+113
| | ["debugpy", "breakpoint" | "listen" | "wait_for_client"] | ||
| | ["ptvsd", "break_into_debugger" | "wait_for_attach"] |
Contributor
Author
There was a problem hiding this comment.
I tried to pick the API methods that looked like they would be most commonly used based on the documentation:
https://github.com/microsoft/debugpy/?tab=readme-ov-file#debugpy-import-usage
https://github.com/microsoft/ptvsd?tab=readme-ov-file#ptvsd-import-usage
Member
There was a problem hiding this comment.
Spot-checked, makes sense to me.
Contributor
|
jeremy-hiatt
force-pushed
the
add-debug-modules-to-t100
branch
from
21ebf18 to
cc56dd2
Compare
charliermarsh
approved these changes
Mar 2, 2024
Member
charliermarsh
left a comment
charliermarsh
left a comment
There was a problem hiding this comment.
This is great, thank you!
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
astral-sh#10194) ## Summary This addresses astral-sh#10177. ## Test Plan I added additional lines to the existing test file for T100.
alexrashed
added a commit
to localstack/localstack
that referenced
this pull request
Mar 12, 2024
ruff 0.3.1 added linting rules to alert on the usage of debugpy with astral-sh/ruff#10194. This commit excludes these lines because it's used for a specific feature (instead of debugging code leaking into the codebase).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses #10177.
Test Plan
I added additional lines to the existing test file for T100.