Use memchr for tab-indentation detection#9853
Merged
Merged
Conversation
Contributor
|
charliermarsh
force-pushed
the
charlie/tabs
branch
from
13c6a41 to
795a9f0
Compare
charliermarsh
force-pushed
the
charlie/tabs
branch
from
795a9f0 to
309f8fe
Compare
charliermarsh
changed the title
memchr for tab-indentation detection
MichaReiser
approved these changes
Feb 6, 2024
Comment on lines
+87
to
+89
| if !indexer.multiline_ranges().contains_range(range) { | ||
| return Some(range); | ||
| } |
Member
There was a problem hiding this comment.
Nit: I believe the rule will now have a false positive for
a = "b\
test"
Member
Author
There was a problem hiding this comment.
I swear I tested this and it wasn't valid but you're totally right. Regardless, we need to solve this for the trailing whitespace rule too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The benchmarks show a pretty consistent 1% speedup here for all-rules, though not enough to trigger our threshold of course: