Improve trailing comma rule performance#9867
Merged
Merged
Conversation
a1e1477 to
d2a1c66
Compare
CodSpeed Performance ReportMerging #9867 will improve performances by 10%Comparing Summary
Benchmarks breakdown
|
538789c to
dee1a37
Compare
charliermarsh
approved these changes
Feb 6, 2024
Member
charliermarsh
left a comment
There was a problem hiding this comment.
I prefer your changes anyway lol.
dee1a37 to
f7076c4
Compare
Contributor
|
nkxxll
pushed a commit
to nkxxll/ruff
that referenced
this pull request
Mar 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure what precisely improves performance but these are the things I did:
flatten,filter_map,chain,coalesce,tuple_windows. Now it's justfilter_mapI would have expected that Rust sees through that but maybe it does not.TokenTypevariants to matchTok.... I doubt that this has any impactToken::fromfrom&Spannedto(&Tok, TextRange).context.last()when we already set the context in the branch aboveTest Plan
cargo test