Fix bug when creating a sqlite database via Felis#87
Merged
kelle merged 1 commit intoastrodbtoolkit:mainfrom Dec 11, 2024
Merged
Fix bug when creating a sqlite database via Felis#87kelle merged 1 commit intoastrodbtoolkit:mainfrom
kelle merged 1 commit intoastrodbtoolkit:mainfrom
Conversation
kelle
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was that if a connection_string specified some directory structure, this was ignored when attaching the database. This meant that two copies of the file were created and one of them was completely empty of tables.