fwhm min/max: produce results for N_FWHM < 4#22
Open
dstndstn wants to merge 1 commit intoastromatic:masterfrom
Open
fwhm min/max: produce results for N_FWHM < 4#22dstndstn wants to merge 1 commit intoastromatic:masterfrom
dstndstn wants to merge 1 commit intoastromatic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small fix allows the code to work with very small catalogs. I encountered this in one of my unit test cases that uses tiny images -- 8 sources in this case, with Nfwhm here being 3.
In my case, this ended up computing
fwhmmin = 2andfwhmmax = 0, so all stars got eliminated by the FWHM check.In the code, it looks like you planned to handle this case by forcing
nwto be at least 1, but then in theforloop thenwis recomputed without that check.