[PM-804] fix(parse): support airflow.sdk Variable in astro dev parse #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DAGs use the new Airflow 3.x recommended import style `from airflow.sdk import Variable`, the existing monkey patch for `airflow.models.Variable.get` was not being applied. This caused `astro dev parse` to fail with "Variable not found" errors when using remote backends like Azure Key Vault. This fix extends the Variable.get monkey patch to also apply to `airflow.sdk.Variable`, ensuring DAG parsing works correctly for both the legacy `airflow.models.Variable` and the new `airflow.sdk.Variable` import styles. Fixes PM-804 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build b0c34e8f-5b58-48fb-91dc-ee6de3b6c95dDetails
💛 - Coveralls |
jlaneve
requested review from
jeremybeard,
kushalmalani and
neel-astro
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
airflow.sdk.Variableastro dev parseworks correctly for DAGs using the new Airflow 3.x recommended import style (from airflow.sdk import Variable)Context
Customer upgrading from Airflow 3.1.2 to 3.1.3 was blocked because
astro dev parsefails when DAGs useairflow.sdkVariable.get with Azure Key Vault as the backend.The existing test harness only monkey-patched
airflow.models.Variable.get, so when imports are updated to useairflow.sdk(the new recommended approach in Airflow 3.x), the parse step makes real calls and fails withVariable not found.Test plan
astro dev parseworks with DAGs usingfrom airflow.sdk import Variableastro dev parsestill works with DAGs usingfrom airflow.models import Variable🤖 Generated with Claude Code