Skip to content

Conversation

@collinmcnulty
Copy link
Contributor

If a user is doing secondary manipulation of a filesystem to create a dags/ folder from multiple sources, the check on dags/ being changed in the diff will fail even though only dags have changed. This makes sense for infer, but we need to have an option where the user's indication that this is a dag-only deploy is trusted.

@collinmcnulty collinmcnulty requested a review from a team as a code owner January 31, 2025 21:14
Copy link
Collaborator

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would start creating a problem when someone has configured multiple deploy action steps in their workflow, i.e. one for dbt deploy, another for dags deploy, and then one for image deploy.

In that case, as of now, we would only be triggering an image deploy for the case when there is a change outside the dags and dbt folder, but with this change, we would end up triggering both dags deploy and image deploy for such changes, which feels wrong.

Maybe having something like a skip-check parameter would be useful to skip these checks and simply do dag/dbt/image deploy if the deploy type is anything but infer. That would ensure existing workflow setups are not impacted.

@collinmcnulty
Copy link
Contributor Author

In that case, as of now, we would only be triggering an image deploy for the case when there is a change outside the dags and dbt folder, but with this change, we would end up triggering both dags deploy and image deploy for such changes, which feels wrong.

This feels very strange to me. If you want to only trigger an action when certain files are change, GitHub Actions gives you the tools to do so with on. If you trigger an action, it should do the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants