New keyword argument supports user-defined halo boundary#995
Merged
aphearin merged 7 commits intoastropy:masterfrom Sep 18, 2020
Merged
New keyword argument supports user-defined halo boundary#995aphearin merged 7 commits intoastropy:masterfrom
aphearin merged 7 commits intoastropy:masterfrom
Conversation
…de the enforcement of consistent column names between halo mass and halo boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should resolve #993. Previously, the user supplied only the halo mass column name, and halotools enforced a specific string pattern for the column name in the halo catalog associated with the halo mass definition. This PR allows users to pass in a halo_boundary_key kwarg that overrides this choice.