feat: add max-queued-records-per-shard metric (cherry-pick Confluent #905)#43
Open
astubbs wants to merge 1 commit intocherry-pick/893-offset-resetfrom
Open
feat: add max-queued-records-per-shard metric (cherry-pick Confluent #905)#43astubbs wants to merge 1 commit intocherry-pick/893-offset-resetfrom
astubbs wants to merge 1 commit intocherry-pick/893-offset-resetfrom
Conversation
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
2f34442 to
5fa45f5
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
✅ Duplicate Code ReportTwo engines run in parallel for cross-validation. Each has its own thresholds tuned to its baseline - the real safety net is the per-engine "max increase vs base" check. ✅ PMD CPD
No new clones introduced by this PR. ✅ jscpd (language-agnostic)
No new clones introduced by this PR. Powered by astubbs/duplicate-code-cross-check |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cherry-pick/893-offset-reset #43 +/- ##
===============================================================
Coverage ? 77.16%
Complexity ? 1156
===============================================================
Files ? 82
Lines ? 4195
Branches ? 387
===============================================================
Hits ? 3237
Misses ? 767
Partials ? 191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
❌ Mutation Testing (PIT) ReportPIT did not produce a report. Most commonly this means a test failed in the baseline (PIT runs all tests unmodified first to establish green) and PIT aborted before mutating. See the "Run PIT mutation testing" step logs for the failing test, then either fix it or add it to |
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
94c35dd to
e9a5dd3
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
5fa45f5 to
32ba213
Compare
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
e9a5dd3 to
11c9aca
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
32ba213 to
0be2aef
Compare
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
11c9aca to
9d5778b
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
0be2aef to
f63e753
Compare
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
9d5778b to
fa956d8
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
f63e753 to
e4693a0
Compare
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
fa956d8 to
fab5b0b
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
e4693a0 to
f125b26
Compare
✅ SpotBugs ReportNo bugs found (new bugs only — baseline from base branch excluded). |
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
fab5b0b to
a35c7db
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
f125b26 to
5476dc4
Compare
…onfluentinc#905) Cherry-pick of confluentinc#905 (author: flashmouse). Adds a SHARDS_MAX_SIZE gauge that reports the record count in the most-loaded shard. Useful with KEY ordering to detect hot-key bottlenecks. Also simplifies .keySet().size() to .size(). Upstream PR: confluentinc#905 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
astubbs
force-pushed
the
cherry-pick/893-offset-reset
branch
from
a35c7db to
44c72f5
Compare
astubbs
force-pushed
the
cherry-pick/905-max-shard-metric
branch
from
5476dc4 to
53f496b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of confluentinc/parallel-consumer#905 by flashmouse.
SHARDS_MAX_SIZEgauge: reports the record count in the most-loaded shardKEYordering to detect hot-key bottlenecks at a glance.keySet().size()to.size()on the shards map2 files changed, 6 insertions, 1 deletion. Self-contained observability win.
Partial progress toward upstream issues #27 (Micrometer metrics) and confluentinc#71 (health checks).
depends on #42
Test plan
🤖 Generated with Claude Code