Adding Converse method to BedrockRuntime client#1861
Adding Converse method to BedrockRuntime client#1861victor-upmeet wants to merge 11 commits intoasync-aws:masterfrom
Conversation
|
Looks like the CodeGenerator has an inconsistency in its handling of objects without properties. |
|
The shape description uses |
|
I discovered that This also seems something new in those API declarations. |
|
I opened #1882 to track the support for document shapes in the code generator |
| "message":{ | ||
| "content":[ | ||
| { | ||
| "role":"user", |
There was a problem hiding this comment.
this "role": "user" should be a key in the Message object, not in the ContentBlock object (this is why the tests are failing)
| "content":[ | ||
| { | ||
| "role":"user", | ||
| "content":{ |
There was a problem hiding this comment.
This looks suspicious to me. https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_Message.html says that content is an array of content blocks. Those content blocks don't have an additional content key
|
With #2019 implementing union shapes, this work could be restarted. |
Hi there
This PR implements the Converse method to the BedrockRuntime client. However, I am facing some issues with the generated code that makes the tests to fail.
In the static analysis, tests fail because constructors are not implemented on some classes, but these same classes are instanciated with arguments. There are also some failures due to wrong documentation types.
In the CI tests, I have a "Undefined index: role" error originating inside the ConverseResponse class in the generated code.
If I can do anything to help let met know, but as far as I understand, the issue seems to be cause by the code generator.