fix: use correct start scripts for federations#73
Merged
sunli829 merged 2 commits intoasync-graphql:masterfrom Nov 18, 2023
Merged
fix: use correct start scripts for federations#73sunli829 merged 2 commits intoasync-graphql:masterfrom
sunli829 merged 2 commits intoasync-graphql:masterfrom
Conversation
Contributor
xoac
commented
Oct 13, 2023
xoac
commented
- The start.sh scripts is now in correct folder
- cleanup functions try kill all PIDs (it didn't worked if one of process exited on it's own - for example when address was in use).
|
@xoac we also need to update the README.md files to reference port 4000 instead of port 3000 as rover starts the router on port 4000 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.