Remove EtcdLock and apply breaking changes to lock interface#12
Merged
JulianVennen merged 17 commits intoaternosorg:masterfrom Apr 4, 2025
Merged
Remove EtcdLock and apply breaking changes to lock interface#12JulianVennen merged 17 commits intoaternosorg:masterfrom
JulianVennen merged 17 commits intoaternosorg:masterfrom
Conversation
matthi4s
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Locknow implementsLockInterfacesetBreakOnDestruct,setIdentifierandupdatenow return the lock instance ($this)break()no longer performs unnecessary requests if the lock is not presentgetRemainingLockDurationwhich returns the remaining duration a lock is valid for.Breaking Changes
EtcdLock. UseLockandLock->lock()instead.LockInterfaceno longer acquires the lock. Use->lock()insteadlock,refreshandwaitForOtherLocksare now properties of the lock itself.Lock->isLocked()now returns true if the lock is still valid. To get the remaining duration of the lock, usegetRemainingLockDuration()Lock->break()andLock->removeLock()now return void instead of always returning trueLock->$identifieris no longer nullable, but a null value can still be passed in the constructor to use the default identifierLock->getClient()is now static