Closed
Conversation
…om `master` as we can get away with
…formance improvements
This is an upstream port of decaffeinate#10 See that PR for links to the issues that this fixes. Just like OUTDENT and CALL_END tokens, close-curly-brace tokens can be generated without having a real location, and if that position overlaps with a later token, it can cause the AST to have bad location data. Just like the other two token types, we now give `}` tokens the position of the previous real token, which makes all AST nodes have reasonable locations.
…ated-close-curly-location Include generated } tokens when fixing closing token positions
atg
reviewed
Nov 1, 2016
src/lexer.coffee
Outdated
| if @value() is '!' | ||
| poppedToken = @tokens.pop() | ||
| id = '!' + id | ||
| else if id is 'from' and @seenFor |
Owner
There was a problem hiding this comment.
Won't this break if tag is 'PROPERTY'?
Author
There was a problem hiding this comment.
You should add a test for that :) This change didn't break any tests.
If it needs that check, I would just change this to else if tag is 'IDENTIFIER' and id is 'from' and @seenFor
…s.coffee; improve error message so that "own" is underlined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the lexer if block, general cleanup for style.
I’m leaving for you the task of moving the compilation error tests into
error_messages.coffee.